Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dnsdist: Document that RE2 does full matching, add regression tests #15111

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Feb 3, 2025

Short description

Closes #15099

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Feb 3, 2025

Pull Request Test Coverage Report for Build 13114457556

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 760 unchanged lines in 24 files lost coverage.
  • Overall coverage decreased (-0.01%) to 64.702%

Files with Coverage Reduction New Missed Lines %
pdns/misc.cc 1 62.6%
pdns/pollmplexer.cc 1 83.66%
pdns/recursordist/sortlist.cc 2 74.12%
pdns/tcpiohandler.cc 2 68.3%
modules/lmdbbackend/lmdbbackend.cc 2 73.65%
pdns/inflighter.cc 3 90.48%
pdns/iputils.cc 3 56.99%
modules/gpgsqlbackend/spgsql.cc 3 67.94%
pdns/pdnsexception.hh 3 25.0%
pdns/communicator.hh 5 77.78%
Totals Coverage Status
Change from base Build 13112383883: -0.01%
Covered Lines: 127874
Relevant Lines: 166538

💛 - Coveralls

Co-authored-by: Miod Vallat <miod.vallat@open-xchange.com>
Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^Looking good.$
^Don't forget to update the spell checker list of odd words as well.$

@rgacogne rgacogne merged commit eea920f into PowerDNS:master Feb 3, 2025
81 checks passed
@rgacogne rgacogne deleted the dist-re2 branch February 3, 2025 14:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist: RE2Rule() not working
3 participants