Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

s3: add TLS configuration options #5

Merged
merged 2 commits into from
May 31, 2022
Merged

s3: add TLS configuration options #5

merged 2 commits into from
May 31, 2022

Conversation

wojas
Copy link
Member

@wojas wojas commented May 31, 2022

Use github.com/PowerDNS/go-tlsconfig for TLS configuration.
@wojas wojas requested a review from nvaatstra May 31, 2022 14:32
The TLS manager needs a longer running context unconstrained by
InitTimeout to automatically reload certificates.
Copy link
Contributor

@nvaatstra nvaatstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, defaults from the manager also seem in line with the aws sdk.

@wojas wojas merged commit d92e24d into main May 31, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants