Skip to content

Use TLS 1.2 for bootstrapping dotnet in CI #1047

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Jul 27, 2018

PR Summary

See this breaking change here, whereby https://dot.net switched to using TLS 1.2-only
dotnet/announcements#77

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking
  • NA Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister bergmeister changed the title Use tls 1.2 for bootstrapping dotnet in CI Use TLS 1.2 for bootstrapping dotnet in CI Jul 27, 2018
@bergmeister bergmeister requested a review from TravisEz13 July 27, 2018 07:41
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be secure

@bergmeister bergmeister merged commit db2aabf into PowerShell:development Jul 27, 2018
bergmeister added a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 22, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants