Add rule to check cmdlet compatibility #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
September 21, 2016 17:41
added 7 commits
September 23, 2016 14:08
kapilmb
force-pushed
the
kapilmb/UseCompatibleCmdlets
branch
from
1418841 to
36fe25a
Compare
bmanikm
reviewed
Sep 24, 2016
| throw new ArgumentNullException("ast"); | ||
| } | ||
|
|
||
| scriptPath = fileName; |
There was a problem hiding this comment.
fileName [](start = 25, length = 8)
Any possibility of this being null or whitespace? or not existing file?
bmanikm
reviewed
Sep 24, 2016
|
|
||
| Function IsPSEditionDesktop | ||
| { | ||
| $PSEdition -eq $null -or $PSEdition -eq 'Desktop' |
There was a problem hiding this comment.
$PSEdition -eq $null -or $PSEdition -eq 'Desktop' [](start = 4, length = 49)
use below here
(Get-PSVariable -Name PSEdition -ErrorAction Ignore) -or ($PSEdition -eq 'Desktop')
There was a problem hiding this comment.
Is it Get-Variable or Get-PSVariable?
There was a problem hiding this comment.
Yes, it should be Get-Variable only. Thanks!
bmanikm
reviewed
Sep 24, 2016
| { | ||
| $null | ||
| } | ||
| $root |
There was a problem hiding this comment.
use below
if ((Test-Path (Join-Path $root $solutionFilename)))
{
$root
}
bmanikm
reviewed
Sep 24, 2016
| { | ||
| $null | ||
| } | ||
| Join-Path $slnRoot "Rules" |
There was a problem hiding this comment.
use below
if ($slnRoot)
{
Join-Path $slnRoot "Rules"
}
bmanikm
reviewed
Sep 24, 2016
| { | ||
| $null | ||
| } | ||
| Join-Path $prjRoot "ScriptAnalyzerBuiltinRules.csproj" |
|
|
|
@bmanikm Thanks! |
kapilmb
force-pushed
the
kapilmb/UseCompatibleCmdlets
branch
from
ad039ae to
7406fc0
Compare
kapilmb
force-pushed
the
kapilmb/UseCompatibleCmdlets
branch
from
7406fc0 to
8adbda8
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #605
This change is