-
Notifications
You must be signed in to change notification settings - Fork 395
Add Ubuntu Build+Test to Appveyor CI #940
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Ubuntu Build+Test to Appveyor CI #940
Conversation
…veyor environment
…sed this works in WMF as well)
…aningful (again fingers crossed for the WMF 4 build)
…hich have to install the .net sdk from scratch
…image, let's hope it works for WMF 4 as well)
…nalyzer into pwshBuild_Ubuntu # Conflicts: # appveyor.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this looks great - how do we report on the build? Does it get rolled into the current badge? Both pass or it's a fail?
In total we have 4 builds (WMF 4, WMF5, PS6 on Windows, PS6 on Ubuntu) and if any of them fail, the badge should be red. One can still click on the result and see which of the 4 builds failed and dill into it: |
really happy to broaden our CI builds! |
PR Summary
This is based on PR 939 (that enables build+test using PowerShell Core) and contains only small tweaks to also build and run on Ubuntu using the private beta of Appveyor.
The main difference is that
ps
tasks also get run aspwsh
PowerShell Core tasks on Linux in AppVeyor but PowerShell Core tasks do not persist the session, therefore additionalImport-Module
calls were needed.To fix the build, one rule was in a 'rules' folder instead of 'Rules', therefore the casing of the folder had to be corrected.
Note that AppVeyor for Linux ix currently in private Beta but I think the risk of breaking changes is low and will be probably minor such as e.g. a rename of the image name. Currently the Ubuntu image has the version
16.04.4 LTS
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets. Please mark anything not applicable to this PRNA
.NA
User facing documentation neededNA
Make sure you've added a new test if existing tests do not effectively test the code changedWIP:
to the beginning of the title and remove the prefix when the PR is ready