Skip to content

Fix tilde expand for Windows paths with backslashes #768

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 6, 2025
Merged

Fix tilde expand for Windows paths with backslashes #768

merged 3 commits into from
Jan 6, 2025
+47 −26

Conversation

tgauth
Copy link
Collaborator

@tgauth tgauth commented Dec 3, 2024

PR Summary

  • update tilde_expand() logic for Windows paths with backslashes
  • add pester tests for basic tilde_expand() scenarios

PR Context

@tgauth tgauth requested a review from vthiebaut10 December 3, 2024 18:21
darikprescott
darikprescott reviewed Dec 4, 2024
View reviewed changes
Copy link

@darikprescott darikprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making great things happen!

@tgauth tgauth merged commit cdcc8d3 into PowerShell:latestw_all Jan 6, 2025
4 checks passed
@tgauth tgauth deleted the fix-tilde-expand branch January 6, 2025 19:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@darikprescott darikprescott darikprescott left review comments

@vthiebaut10 vthiebaut10 vthiebaut10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tilde_expand in client fails to resolve path
3 participants
@tgauth @darikprescott @vthiebaut10