Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

respect PREFECT_SERVER_LOGGING_LEVEL in prefect server start #16765

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Jan 17, 2025

#16651 introduced a regression where PREFECT_SERVER_LOGGING_LEVEL was not respected when starting a server via prefect server start, we need to pass the log_level to uvicorn

original report

@zzstoatzz zzstoatzz changed the title use settings respect PREFECT_SERVER_LOGGING_LEVEL in prefect server start Jan 17, 2025
Copy link

codspeed-hq bot commented Jan 17, 2025

CodSpeed Performance Report

Merging #16765 will not alter performance

Comparing use-server-logging-settings (c4d29c2) with main (6b560c8)

Summary

✅ 2 untouched benchmarks

@zzstoatzz zzstoatzz marked this pull request as ready for review January 17, 2025 23:43
@zzstoatzz zzstoatzz added fix A fix for a bug in an existing feature cli Related to the Prefect CLI labels Jan 17, 2025
@zzstoatzz zzstoatzz merged commit a634b49 into main Jan 20, 2025
56 checks passed
@zzstoatzz zzstoatzz deleted the use-server-logging-settings branch January 20, 2025 18:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cli Related to the Prefect CLI fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants