Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix all typing errors in prefect.runner.runner #16797

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

desertaxle
Copy link
Member

This PR fixes all typing errors for the Runner. I want to refactor the Runner a bit and starting out with no red squiggles will make that easier.

Copy link

codspeed-hq bot commented Jan 21, 2025

CodSpeed Performance Report

Merging #16797 will not alter performance

Comparing fix-runner-typing-errors (ddf1080) with main (310612b)

Summary

✅ 2 untouched benchmarks

@desertaxle desertaxle marked this pull request as ready for review January 21, 2025 20:22
@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Jan 21, 2025
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM but left a question

@desertaxle desertaxle merged commit 5fdc903 into main Jan 22, 2025
51 checks passed
@desertaxle desertaxle deleted the fix-runner-typing-errors branch January 22, 2025 15:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants