Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix serializtion for FlowRunContext for flow runs kicked off from a deployment #16831

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Fix serializtion for FlowRunContext for flow runs kicked off from a deployment #16831

merged 3 commits into from
Jan 23, 2025

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jan 23, 2025 •
edited
Loading

Closes #16766
Closes #16756

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 23, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #16831 will not alter performance

Comparing fix-flow-context-serialization (7d75746) with main (131136b)

Summary

✅ 2 untouched benchmarks

@github-actions github-actions bot added the bug Something isn't working label Jan 23, 2025
@desertaxle desertaxle marked this pull request as ready for review January 23, 2025 20:06
cicdw
cicdw approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+ testing-as-documentation-and-as-micro-blog skills on display

zzstoatzz
zzstoatzz approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice test 🫡

tests/test_context.py
)

# Define a wrapper function to ensure environment variables and settings propagate because
# PYTHON WON'T DO IT FOR US
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫠

@desertaxle desertaxle merged commit 1f7dc91 into main Jan 23, 2025
48 checks passed
@desertaxle desertaxle deleted the fix-flow-context-serialization branch January 23, 2025 20:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@zzstoatzz zzstoatzz zzstoatzz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@desertaxle @cicdw @zzstoatzz