Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix subtraction logic on non-input cache policies #16840

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jan 23, 2025

This PR implements @a14e's suggested bug fix as discussed here.

In particular, cache policies which do not already rely on run inputs should not implicitly begin relying on run inputs just because the subtraction operator was used.

@cicdw cicdw added the fix A fix for a bug in an existing feature label Jan 23, 2025
Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #16840 will not alter performance

Comparing fix-cache-policy-subtraction (c674e62) with main (ff0f3db)

Summary

✅ 2 untouched benchmarks

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cicdw cicdw merged commit 5f1ebb5 into main Jan 23, 2025
50 checks passed
@cicdw cicdw deleted the fix-cache-policy-subtraction branch January 23, 2025 21:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants