Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Experimental] Enhancement: Lineage interface event names and context resource registration #16842

Conversation

znicholasbrown
Copy link
Contributor

This PR updates the experimental external lineage interface introduced in #16820 to allow passing an event name; this name will be recorded only for the direct connection between lineage resources. It also fixes a bug where context resources weren't being registered as lineage resources in the global namespace.

cc @kevingrismore

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

… make sure context resources are registered as lineage resources in the global namespace
Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #16842 will not alter performance

Comparing 2025-01-23/lineage/experimental-event-names-and-context-registration (2afce8d) with main (5f1ebb5)

Summary

✅ 2 untouched benchmarks

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevingrismore kevingrismore merged commit dbd7bc6 into main Jan 24, 2025
49 checks passed
@kevingrismore kevingrismore deleted the 2025-01-23/lineage/experimental-event-names-and-context-registration branch January 24, 2025 15:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants