Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove @sync_compatible from prefect.artifacts #16877

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jan 28, 2025

Related to #15008

I also addressed the pyright errors in tests/test_artifacts.py, which is why the diff is a bit messy.

Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #16877 will not alter performance

Comparing remove-sync-compatible-artifacts (c02624d) with main (c2e0a1e)

Summary

✅ 2 untouched benchmarks

@desertaxle desertaxle marked this pull request as ready for review January 28, 2025 22:00
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@desertaxle desertaxle merged commit e441d14 into main Jan 29, 2025
50 checks passed
@desertaxle desertaxle deleted the remove-sync-compatible-artifacts branch January 29, 2025 12:35
@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Jan 29, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants