Bumps to ruff==0.9.2 and mypy==1.14.1
#16916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here I've bumped our pre-commit version of ruff to 0.9.2, which did entail a very large amount of formatting churn. The only major change here besides formatting is that I'm pinning the linter/formatter dependencies in `requirements-dev.txt` to the version we have in pre-commit. This helps avoid IDE "fighting" with pre-commit when folks installing `prefect`'s dev dependencies pick up a newer version of the linter than the pre-commit defines. Hopefully this will make contributions from other folks easier.
chrisguidry
requested review from
aaazzam,
kevingrismore,
daniel-prefect,
seanpwlms,
cicdw,
desertaxle and
zzstoatzz
as code owners
github-actions
bot
added
docs
upstream dependency
chrisguidry
commented
Jan 30, 2025
| rev: "v0.2.1" | ||
| rev: v0.9.2 |
There was a problem hiding this comment.
Relevant change
chrisguidry
commented
Jan 30, 2025
requirements-dev.txt
Outdated
Comment on lines
28
to
34
| # Linters and dev tools that are also in .pre-commit-config.yaml, which | ||
| # should usually be updated together. | ||
| codespell==2.2.6 | ||
| ruff==0.9.2 | ||
| mypy==1.9.0 | ||
| vermin==1.6.0 | ||
|
|
There was a problem hiding this comment.
Relevant changes
CodSpeed Performance ReportMerging #16916 will not alter performanceComparing Summary
|
desertaxle
reviewed
Jan 31, 2025
Co-authored-by: Alex Streed <desertaxle@users.noreply.github.com>
desertaxle
reviewed
Jan 31, 2025
Co-authored-by: Alex Streed <desertaxle@users.noreply.github.com>
chrisguidry
changed the title
ruff==0.9.2ruff==0.9.2 and mypy==1.14.1
desertaxle
added
development
|
Thanks for the assist, dude! |
aaazzam
approved these changes
Jan 31, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I've bumped our pre-commit version of ruff to 0.9.2, which did
entail a very large amount of formatting churn.
The only major change here besides formatting is that I'm pinning the
linter/formatter dependencies in
requirements-dev.txtto the versionwe have in pre-commit. This helps avoid IDE "fighting" with pre-commit
when folks installing
prefect's dev dependencies pick up a newerversion of the linter than the pre-commit defines. Hopefully this will
make contributions from other folks easier.
Checklist
<link to issue>"mint.json.