Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[UI v2] feat: Moves delete deployment confirmation dialog logic to a re-usable hook #17001

Merged

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 5, 2025

Moves logic for deleting deployment confirmation dialog to a re-usable hook.
This re-usable hook will be used in the deployment details page for its own action menu.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 5, 2025
@devinvillarosa devinvillarosa force-pushed the move-delete-deployment-logic-to-re-usable-hook branch from 025a522 to 82a577f Compare February 6, 2025 19:59
@devinvillarosa devinvillarosa marked this pull request as ready for review February 6, 2025 20:01
@devinvillarosa devinvillarosa force-pushed the move-delete-deployment-logic-to-re-usable-hook branch from 82a577f to 3fa45ba Compare February 6, 2025 20:13
@devinvillarosa devinvillarosa merged commit a02cc8d into main Feb 6, 2025
9 checks passed
@devinvillarosa devinvillarosa deleted the move-delete-deployment-logic-to-re-usable-hook branch February 6, 2025 20:15
kevingrismore pushed a commit that referenced this pull request Feb 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants