[UI v2] feat: Adds deployment metadata #17023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinvillarosa
force-pushed
the
deployment-id-details
branch
from
87763b7 to
d8a6655
Compare
devinvillarosa
force-pushed
the
deployment-id-details
branch
from
d8a6655 to
1c7d4e9
Compare
devinvillarosa
requested review from
aaazzam,
desertaxle,
devangrose and
pleek91
as code owners
devinvillarosa
commented
Feb 6, 2025
There was a problem hiding this comment.
Fixing this key name
pleek91
approved these changes
Feb 6, 2025
| key: "Infrastructure Document ID", | ||
| value: deployment.infrastructure_document_id, | ||
| }, | ||
| ] as const; |
There was a problem hiding this comment.
curious if this is needed for some reason? usually only needed for types but key: string is probably all we need here.
There was a problem hiding this comment.
I usually just add it so that the TS compiler knows the set size of the array.
But IMO this isn't really needed for this case. Just from habit
|
Going to close this PR. Decided to join the data together for the side details |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds deployment metadata
Checklist
<link to issue>"mint.json.Relates to #15512