Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[UI v2] feat: Adds Deployment configuration tab #17063

Merged
merged 1 commit into from
Feb 10, 2025
Merged

[UI v2] feat: Adds Deployment configuration tab #17063

merged 1 commit into from
Feb 10, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 8, 2025 •
edited
Loading

  1. Adds Deployment configuration tab
  2. Updates JsonInput component to support a copy feature as a prop
Screen.Recording.2025-02-07.at.11.47.38.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 8, 2025
@devinvillarosa devinvillarosa force-pushed the deployment-configuration branch 2 times, most recently from 1e8f809 to 0eed8a9 Compare February 10, 2025 17:15
@devinvillarosa devinvillarosa marked this pull request as ready for review February 10, 2025 17:16
@devangrose
Copy link
Contributor

Just the lint error but looks solid!

@devinvillarosa devinvillarosa force-pushed the deployment-configuration branch from 0eed8a9 to 6d92c23 Compare February 10, 2025 17:19
@devinvillarosa devinvillarosa merged commit 35a86f4 into main Feb 10, 2025
9 checks passed
@devinvillarosa devinvillarosa deleted the deployment-configuration branch February 10, 2025 17:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@devangrose devangrose devangrose approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@pleek91 pleek91 Awaiting requested review from pleek91 pleek91 is a code owner

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @devangrose