Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consolidate pendulum usage in prefect.server.services #17100

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

desertaxle
Copy link
Member

Related to #16910

Copy link

codspeed-hq bot commented Feb 11, 2025

CodSpeed Performance Report

Merging #17100 will not alter performance

Comparing remove-pendulum-from-services (622a463) with main (955378c)

Summary

✅ 2 untouched benchmarks

@desertaxle desertaxle marked this pull request as ready for review February 11, 2025 20:02
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

just to make sure im understanding, you're using - timedelta(...) instead of subtract intentionally to avoid coupling ourselves to the pendulum API right? and the typing for that works out fine?

@desertaxle
Copy link
Member Author

you're using - timedelta(...) instead of subtract intentionally to avoid coupling ourselves to the pendulum API right?

Yup, I'm trying to avoid using pendulum specific methods on DateTime wherever I can.

@desertaxle desertaxle merged commit 949e865 into main Feb 11, 2025
50 checks passed
@desertaxle desertaxle deleted the remove-pendulum-from-services branch February 11, 2025 20:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants