Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[UI v2] chore: move artifact type.d.ts to just types.ts #17107

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 11, 2025

Updates artifact type.d.ts to just types.ts

Found a good thread saying why this pattern isn't supported: microsoft/TypeScript#52593 (comment)

And a good video explanation: https://www.youtube.com/watch?v=zu-EgnbmcLY

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 11, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review February 11, 2025 23:07
@devinvillarosa devinvillarosa merged commit e6f9972 into main Feb 11, 2025
19 checks passed
@devinvillarosa devinvillarosa deleted the rename-artifact-types-file branch February 11, 2025 23:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants