Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Increase default database timeout to 5 seconds #7246

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Oct 19, 2022

Will help with issues like #7190

Increases the default database query timeout from 1s -> 5s
Keeps a 1s timeout during tests so we can keep an eye on slow queries.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • [ ] This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@zanieb zanieb requested a review from cicdw as a code owner October 19, 2022 17:59
@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit f3b5100
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/63503b133f8ba2000812f82f
😎 Deploy Preview https://deploy-preview-7246--prefect-orion.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zanieb zanieb added the enhancement An improvement of an existing feature label Oct 19, 2022
Copy link
Contributor

@abrookins abrookins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@zanieb zanieb merged commit 1d266a1 into main Oct 19, 2022
@zanieb zanieb deleted the databse-timeout-bumpo branch October 19, 2022 19:53
@thomasfrederikhoeck
Copy link
Contributor

@madkinsz I don't think the docstring was fixed here :-)

"""A statement timeout, in seconds, applied to all database
interactions made by the API. Defaults to 1.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants