Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EditorConfig support #2471

Merged
merged 4 commits into from
Jul 10, 2020
Merged

Conversation

osipxd
Copy link
Contributor

@osipxd osipxd commented Jul 10, 2020

Tried to add EditorConfig support. Please check if I've done it right.
image

Closes #2462

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this language definition @osipxd!

I have a few minor suggestions but overall, it looks really good. Great work!

components/prism-editorconfig.js Outdated Show resolved Hide resolved
components/prism-editorconfig.js Show resolved Hide resolved
components/prism-editorconfig.js Outdated Show resolved Hide resolved
components/prism-editorconfig.js Outdated Show resolved Hide resolved
components/prism-editorconfig.js Outdated Show resolved Hide resolved
@osipxd osipxd requested a review from RunDevelopment July 10, 2020 21:47
@RunDevelopment RunDevelopment merged commit ed8fff9 into PrismJS:master Jul 10, 2020
@RunDevelopment
Copy link
Member

Thank you for contributing @osipxd!

@osipxd osipxd deleted the feature/editorconfig branch July 13, 2020 11:01
quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EditorConfig syntax highlight support
2 participants