Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added support for .gitignore #2481

Merged
merged 7 commits into from
Jul 22, 2020
Merged

Added support for .gitignore #2481

merged 7 commits into from
Jul 22, 2020

Conversation

osipxd
Copy link
Contributor

@osipxd osipxd commented Jul 22, 2020 •
edited
Loading

Closes #2475

I've called the main language ignore because it can be used in many ignore configs. Like .hgignore or .npmignore.
Implementation inspired with .ignore plugin.

@osipxd osipxd force-pushed the feature/gitignore branch from e1da8a6 to d7b14fa Compare July 22, 2020 10:43
@osipxd osipxd changed the title Added support fro .gitignore Added support for .gitignore Jul 22, 2020
RunDevelopment
RunDevelopment requested changes Jul 22, 2020
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @osipxd for this language definition!

A few minor nits and one questions:
What are headers and sections? The spec doesn't mention those.

Also, it might be nice to have an alias for .npmignore files edit: and .hgignore files.

components/prism-ignore.js Outdated Show resolved Hide resolved
components/prism-ignore.js Outdated Show resolved Hide resolved
components/prism-ignore.js Outdated Show resolved Hide resolved
components/prism-ignore.js Outdated Show resolved Hide resolved
@osipxd
Copy link
Contributor Author

osipxd commented Jul 22, 2020 •
edited
Loading

What are headers and sections? The spec doesn't mention those.

It isn't from specification it is just additional highlight to better structurize gitignore file in case if it is large.
I'll remove section and header if you think it will be better.
image

Also, it might be nice to have an alias for .npmignore files edit: and .hgignore files.

Ok, I'll add it

@osipxd osipxd requested a review from RunDevelopment July 22, 2020 13:01
@osipxd osipxd force-pushed the feature/gitignore branch from 30d0a3c to f7a8e29 Compare July 22, 2020 13:06
@RunDevelopment
Copy link
Member

It isn't from specification it is just additional highlight to better structurize gitignore file in case if it is large.

It tried searching for this practice and I wasn't able to find anything. It doesn't seem to be common, so let's just go with the spec for now and remove section and header.

@RunDevelopment RunDevelopment merged commit 3fcce6f into PrismJS:master Jul 22, 2020
@RunDevelopment
Copy link
Member

Thank you for contributing @osipxd!

quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
@osipxd @quentinvernot
Added support for .gitignore (PrismJS#2481)
547441e
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
language-definitions needs changes new language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add gitignore support
2 participants
@osipxd @RunDevelopment