pass explicit secrets to reusable workflow

PrismLibrary · May 31, 2022 · efdeec0 · efdeec0
1 parent 004804c
commit efdeec0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/.github/workflows/build-packages.yml b/.github/workflows/build-packages.yml
@@ -72,16 +72,16 @@ jobs:
     if: ${{ github.event_name != 'pull_request' }}
     with:
       name: Deploy Internal
+    secrets: 
       feedUrl: ${{ secrets.IN_HOUSE_NUGET_FEED }}
       apiKey: ${{ secrets.IN_HOUSE_API_KEY }}
-    secrets: inherit
 
   deploy-sponsors:
     uses: ./.github/workflows/deploy.yml
     needs: build
     if: ${{ github.event_name != 'pull_request' }}
     with:
       name: Deploy Sponsor Connect
+    secrets:
       feedUrl: ${{ secrets.SPONSOR_CONNECT_NUGET_FEED }}
       apiKey: ${{ secrets.SPONSOR_CONNECT_TOKEN }}
-    secrets: inherit
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -5,12 +5,6 @@ on:
         required: false
         type: string
         default: Deploy
-      feedUrl:
-        required: true
-        type: string
-      apiKey:
-        required: true
-        type: string
 
 jobs:
   deploy:
@@ -30,5 +24,5 @@ jobs:
         uses: dansiegel/publish-nuget@v1.01
         with:
             filename: 'Artifacts/*.nupkg'
-            feedUrl: ${{ inputs.feedUrl }}
-            apiKey: ${{ inputs.apiKey }}
+            feedUrl: ${{ secrets.feedUrl }}
+            apiKey: ${{ secrets.apiKey }}