Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Migrate Navigation XAML Extensions #22

Closed
dansiegel opened this issue May 7, 2022 · 4 comments · Fixed by #68
Closed

Migrate Navigation XAML Extensions #22

dansiegel opened this issue May 7, 2022 · 4 comments · Fixed by #68
Assignees
Labels
good first issue Good for newcomers

Comments

@dansiegel
Copy link
Member

Description

There are a number of XAML Extensions for Navigation such as the Navigate & GoBack Extensions which have not yet been ported over to MAUI. These need to be migrated over.

@dansiegel dansiegel added the good first issue Good for newcomers label May 7, 2022
@chowarth
Copy link
Contributor

Hi @dansiegel I've got a branch with these changes migrated across. I just need to double check that all the navigation parameter behaviour is working as expected, it should be, I've just not gone through it yet. I'm away for the next 3 weeks, is there any urgency on this being completed before then?

@dansiegel
Copy link
Member Author

I won't say that there is a sense of urgency at this point. We can assign you the issue and you can get a PR in when you get a chance. Enjoy your holiday

@chowarth
Copy link
Contributor

chowarth commented Jun 8, 2022

@dansiegel, I'm in the process of getting everything up-to-date with your recent changes and hopefully this will be good to go. One question I have though; In the navigation extensions there are a couple of methods that made use of Xamarin.Forms.Internals.Log and I'm unsure of what would be used as a replacement?

@dansiegel
Copy link
Member Author

For now:

// TODO: Determine a good way to log

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants