Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable Dynamic-mig feature for HAMi #708

Merged
merged 17 commits into from
Dec 16, 2024
Merged

Enable Dynamic-mig feature for HAMi #708

merged 17 commits into from
Dec 16, 2024

Conversation

archlitchi
Copy link
Collaborator

/kind feature

About dynamic-mig Feature:

  1. Only work on NVIDIA GPUs (A30 or newer)
  2. Need to configure device-plugin configMap to switch mode to 'mig', default is 'hami-core'
  3. User can use dynamic-mig the same way as they use traditional 'hami-core', no more pod-level configuration is needed.
  4. You can create a mixed pool of nodes with 'mig' mode and with 'hami-core' mode.
  5. You can specify only use 'mig' or 'hami-core' in pod annotations
  6. Documents,examples,website pages: to be added

archlitchi and others added 15 commits November 15, 2024 13:18
Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: archlitchi <limengxuan@4paradigm.com>
Signed-off-by: archlitchi <limengxuan@4paradigm.com>
Signed-off-by: archlitchi <limengxuan@4paradigm.com>
Signed-off-by: archlitchi <limengxuan@4paradigm.com>
Signed-off-by: archlitchi <limengxuan@4paradigm.com>
Signed-off-by: archlitchi <limengxuan@4paradigm.com>
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 19.49153% with 285 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/device/nvidia/device.go 6.48% 99 Missing and 2 partials ⚠️
pkg/device/devices.go 0.00% 94 Missing ⚠️
pkg/scheduler/scheduler.go 44.44% 13 Missing and 2 partials ⚠️
pkg/util/util.go 65.78% 13 Missing ⚠️
pkg/device/cambricon/device.go 0.00% 10 Missing ⚠️
pkg/device/hygon/device.go 0.00% 10 Missing ⚠️
pkg/device/mthreads/device.go 0.00% 10 Missing ⚠️
pkg/scheduler/score.go 38.46% 5 Missing and 3 partials ⚠️
pkg/device/ascend/device.go 40.00% 6 Missing ⚠️
pkg/device/iluvatar/device.go 40.00% 6 Missing ⚠️
... and 2 more
Flag Coverage Δ
unittests 37.12% <19.49%> (-1.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/util/types.go 0.00% <ø> (ø)
pkg/device/ascend/device.go 87.30% <40.00%> (-2.38%) ⬇️
pkg/device/iluvatar/device.go 29.86% <40.00%> (-1.08%) ⬇️
pkg/device/metax/device.go 26.85% <40.00%> (-1.31%) ⬇️
pkg/scheduler/nodes.go 90.90% <57.14%> (-9.10%) ⬇️
pkg/scheduler/score.go 64.83% <38.46%> (-2.78%) ⬇️
pkg/device/cambricon/device.go 15.16% <0.00%> (+0.60%) ⬆️
pkg/device/hygon/device.go 18.70% <0.00%> (+0.70%) ⬆️
pkg/device/mthreads/device.go 16.56% <0.00%> (+0.71%) ⬆️
pkg/util/util.go 45.21% <65.78%> (+4.45%) ⬆️
... and 3 more

Signed-off-by: archlitchi <limengxuan@4paradigm.com>
Signed-off-by: archlitchi <limengxuan@4paradigm.com>
@archlitchi
Copy link
Collaborator Author

/approve

@archlitchi archlitchi merged commit e564934 into master Dec 16, 2024
15 of 16 checks passed
@archlitchi archlitchi deleted the dynamicmig branch December 16, 2024 06:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant