Skip to content

adding basic auth #13

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Dec 13, 2022
Merged

adding basic auth #13

merged 2 commits into from
Dec 13, 2022

Conversation

neildsouth
Copy link
Collaborator

Signed-off-by: Neil South neil.south@answerdigital.com

Description

adding a way we can use simple API keys for internal authorization

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth neildsouth requested a review from mocsharp December 12, 2022 18:14
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #13 (d1936af) into develop (7008cde) will decrease coverage by 0.40967%.
The diff coverage is 96.51163%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop         #13         +/-   ##
===================================================
- Coverage   98.61111%   98.20144%   -0.40967%     
===================================================
  Files             10          11          +1     
  Lines            216         278         +62     
  Branches          28          35          +7     
===================================================
+ Hits             213         273         +60     
- Misses             1           3          +2     
  Partials           2           2                 
Flag Coverage Δ
unittests 98.20144% <96.51163%> (-0.40967%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tion/Middleware/EndpointAuthorizationMiddleware.cs 80.00000% <0.00000%> (-10.90910%) ⬇️
...entication/Configurations/AuthenticationOptions.cs 100.00000% <100.00000%> (ø)
...cation/Extensions/IApplicationBuilderExtensions.cs 100.00000% <100.00000%> (ø)
...cation/Extensions/MonaiAuthenticationExtensions.cs 100.00000% <100.00000%> (+2.77778%) ⬆️
...ication/Middleware/BasicAuthorizationMiddleware.cs 100.00000% <100.00000%> (ø)
...ation/Tests/EndpointAuthorizationMiddlewareTest.cs 100.00000% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7008cde...d1936af. Read the comment docs.

Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth neildsouth merged commit 0f62381 into develop Dec 13, 2022
@neildsouth neildsouth deleted the nds_addbasiceauth branch December 13, 2022 14:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants