Skip to content

Update config structure & logging #3

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Dec 2, 2022
Merged

Update config structure & logging #3

merged 8 commits into from
Dec 2, 2022

Conversation

mocsharp
Copy link
Contributor

@mocsharp mocsharp commented Dec 1, 2022

Description

Updated configuration structure as follows:

{
  "MonaiDeployAuthentication": {
    "bypassAuthentication": false,
    "openId": {
      "realm": "TEST-REALM",
      "realmKey": "EncryptionKey",
      "clientId": "monai-app",
      "audiences": [ "monai-deploy" ],
      "claimMappings": {
        "userClaims": [
          {
            "claimType": "user_roles",
            "claimValues": [ "monai-deploy-user" ],
            "endpoints": [ "test" ]
          },
          {
            "claimType": "user_roles",
            "claimValues": [ "pacs-admins" ],
            "endpoints": [ "config" ]
          }
        ],
        "adminClaims": [
          {
            "claimType": "user_roles",
            "claimValues": [ "monai-role-admin" ]
          }
        ]
      }
    }
  }
}

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the enhancement New feature or request label Dec 1, 2022
@mocsharp mocsharp added this to the 0.1.1 milestone Dec 1, 2022
@mocsharp mocsharp self-assigned this Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #3 (d6a5d06) into develop (74a98b1) will increase coverage by 5.24376%.
The diff coverage is 96.42857%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop          #3         +/-   ##
===================================================
+ Coverage   93.36735%   98.61111%   +5.24375%     
===================================================
  Files             10          10                 
  Lines            196         216         +20     
  Branches          21          28          +7     
===================================================
+ Hits             183         213         +30     
+ Misses             6           1          -5     
+ Partials           7           2          -5     
Flag Coverage Δ
unittests 98.61111% <96.42857%> (+5.24375%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tion/Middleware/EndpointAuthorizationMiddleware.cs 90.90909% <84.61538%> (+0.90909%) ⬆️
...cation/Extensions/MonaiAuthenticationExtensions.cs 97.22222% <96.00000%> (-2.77779%) ⬇️
...entication/Configurations/AuthenticationOptions.cs 100.00000% <100.00000%> (+53.33332%) ⬆️
.../Authentication/Extensions/HttpContextExtension.cs 100.00000% <100.00000%> (+20.00000%) ⬆️
...ation/Tests/EndpointAuthorizationMiddlewareTest.cs 100.00000% <100.00000%> (ø)
src/Authentication/Tests/MockJwtTokenHandler.cs 100.00000% <100.00000%> (ø)
src/Authentication/Extensions/ArrayExtensions.cs 100.00000% <0.00000%> (+100.00000%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a98b1...d6a5d06. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp changed the title Add logging Update config structure & logging Dec 1, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit 8893610 into develop Dec 2, 2022
@mocsharp mocsharp deleted the vchang/logging branch December 2, 2022 18:08
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

🎉 This issue has been resolved in version 0.1.1 🎉

The release is available on:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants