Skip to content

Conversation

clyne
Copy link
Contributor

@clyne clyne commented Mar 24, 2022

Fixed #222 - Highlighting all of the Pythia resources from the landing page

This PR addresses the content aspect of #222, adding descriptions and links for webinars, data sets, and cookbooks.

It does not address the aesthetics issues raised by @brian-rose, namely:

"Get rid of text and present a grid/panels of resources; more graphical and inviting"

I suggest we consider opening a second issue to address the aesthetics.

Highlighting all of the Pythia resources from the landing page
@clyne clyne requested a review from a team as a code owner March 24, 2022 22:58
@clyne clyne requested review from jukent and r-ford and removed request for a team March 24, 2022 22:58
@clyne clyne requested review from brian-rose and removed request for r-ford March 24, 2022 22:59
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2022

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: 705e9e2
✅ Deployment Preview URL: https://623dfefbc72165005fbd73d8--projectpythia-org.netlify.app

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @clyne!

Just added a couple of suggested edits.

jukent and others added 2 commits March 25, 2022 11:37
Co-authored-by: Brian Rose <brose@albany.edu>
Co-authored-by: Brian Rose <brose@albany.edu>
Copy link
Contributor

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @clyne Thanks for adding this! I merged @brian-rose 's suggestion.

@clyne clyne requested a review from brian-rose March 25, 2022 17:40
@clyne
Copy link
Contributor Author

clyne commented Mar 25, 2022

@brian-rose, comments addressed. Thanks!

@jukent
Copy link
Contributor

jukent commented Mar 25, 2022

LGTM!

@clyne clyne merged commit 5798acb into main Mar 25, 2022
@clyne clyne deleted the issue_222 branch March 25, 2022 18:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlighting all of the Pythia resources from the landing page
3 participants