Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update replace_step.js #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update replace_step.js #19

wants to merge 2 commits into from

Conversation

jindw
Copy link

@jindw jindw commented Oct 22, 2021

fix gap range : gapFrom = min(from,gapFrom), gapTo=max(to,gapTo)


if the external boundary is reached, there will be no deletion, right?Are there any other ignored problems?

fix gap range  : gapFrom = min(from,gapFrom), gapTo=max(to,gapTo)
@marijnh
Copy link
Member

marijnh commented Oct 24, 2021

What problem does this patch solve?

@jindw
Copy link
Author

jindw commented Oct 25, 2021

What problem does this patch solve?

ReplaceAroundStep data loss during offline collaborative editing [#1216]

Copy link
Author

@jindw jindw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the first patch has a low-level syntax error:

line 146

if ((from.deleted && to.deleted) return null

fixed to:

if (from.deleted && to.deleted) return null

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants