Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Private Node#defaultContentType method used in prosemirror-schema-list #737

Closed
bradleyayers opened this issue Dec 5, 2017 · 2 comments
Closed

Private Node#defaultContentType method used in prosemirror-schema-list #737

bradleyayers opened this issue Dec 5, 2017 · 2 comments

Comments

@bradleyayers
Copy link

In prosemirror-schema-list a private defaultContentType method is used on Node. It seems desirable to restrict prosemirror-schema-list to only use public APIs so that it can serve as an example of how to implement a plugin.
@marijnh
Copy link
Member

marijnh commented Mar 12, 2018

Opened ProseMirror/rfcs#4 to make it easier to do this on top of public methods.

marijnh added a commit to ProseMirror/prosemirror-commands that referenced this issue Mar 22, 2018
@marijnh
Stop using unexported contentMatchAt method
6a06cc8 
Issue ProseMirror/prosemirror#737
marijnh added a commit to ProseMirror/prosemirror-schema-list that referenced this issue Mar 22, 2018
@marijnh
Stop using unexported contentMatchAt method
3ee659f 
Issue ProseMirror/prosemirror#737
@marijnh
Copy link
Member

marijnh commented Mar 22, 2018

Fixed by attached patches.

@marijnh marijnh closed this as completed Mar 22, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradleyayers @marijnh