Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[#3] Implement HCI LE Commands #21

Merged
merged 74 commits into from
Apr 11, 2018
Merged

[#3] Implement HCI LE Commands #21

merged 74 commits into from
Apr 11, 2018

Conversation

jmarkstar
Copy link
Member

@jmarkstar jmarkstar commented Apr 2, 2018 •
edited by colemancda
Loading

What issue does this PR fix?

Fixes #3.

What does this PR Do?

I added the parameter and events for Encryption Command.

Where should the reviewer start?

LowEnergyCommandParameter.swift
LowEnergyEvent.swift
LowEnergyEventParameter.swift
HCITests.swift

Sweet giphy showing how you feel about this PR

Giphy

@jmarkstar jmarkstar requested a review from colemancda April 2, 2018 16:18
@colemancda
Copy link
Member

Result of Integration 1

Duration: 3 minutes and 1 second
Result: All 22 tests passed, but please fix 1 warning.
Test Coverage: 58%

1 similar comment
@colemancda
Copy link
Member

Result of Integration 1

Duration: 3 minutes and 1 second
Result: All 22 tests passed, but please fix 1 warning.
Test Coverage: 58%

@codecov
Copy link

codecov bot commented Apr 2, 2018 •
edited
Loading

Codecov Report

Merging #21 into master will decrease coverage by 0.86%.
The diff coverage is 46.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   73.58%   72.72%   -0.87%     
==========================================
  Files          67       76       +9     
  Lines        8265     9910    +1645     
  Branches      637      713      +76     
==========================================
+ Hits         6082     7207    +1125     
- Misses       2133     2649     +516     
- Partials       50       54       +4
Flag Coverage Δ
#osx 72.72% <46.67%> (-0.87%) ⬇️
Impacted Files Coverage Δ
Sources/HCI.swift 74.28% <ø> (+31.42%) ⬆️
Sources/LowEnergyFeature.swift 94.73% <ø> (ø) ⬆️
Sources/HCIGeneralEvent.swift 100% <ø> (ø) ⬆️
Sources/ATT.swift 73.17% <ø> (ø) ⬆️
Sources/GATT.swift 91.66% <ø> (ø) ⬆️
Sources/HostControllerLocalName.swift 92.85% <ø> (ø) ⬆️
Sources/LowEnergyCommand.swift 100% <ø> (ø) ⬆️
Sources/POSIXError.swift 93.33% <ø> (ø) ⬆️
Sources/BluetoothHostController.swift 100% <ø> (ø) ⬆️
Sources/LowEnergyTestCommands.swift 0% <0%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e638c...aa8d76e. Read the comment docs.

@colemancda
Copy link
Member

Result of Integration 2

Duration: 2 minutes and 29 seconds
Result: Perfect build! All 22 tests passed. 👍
Test Coverage: 58%

3 similar comments
@colemancda
Copy link
Member

Result of Integration 2

Duration: 2 minutes and 29 seconds
Result: Perfect build! All 22 tests passed. 👍
Test Coverage: 58%

@colemancda
Copy link
Member

Result of Integration 2

Duration: 2 minutes and 29 seconds
Result: Perfect build! All 22 tests passed. 👍
Test Coverage: 58%

@colemancda
Copy link
Member

Result of Integration 2

Duration: 2 minutes and 29 seconds
Result: Perfect build! All 22 tests passed. 👍
Test Coverage: 58%

@colemancda
Copy link
Member

Result of Integration 4

Duration: 2 minutes and 25 seconds
Result: Perfect build! All 22 tests passed. 👍
Test Coverage: 58%

3 similar comments
@colemancda
Copy link
Member

Result of Integration 4

Duration: 2 minutes and 25 seconds
Result: Perfect build! All 22 tests passed. 👍
Test Coverage: 58%

@colemancda
Copy link
Member

Result of Integration 4

Duration: 2 minutes and 25 seconds
Result: Perfect build! All 22 tests passed. 👍
Test Coverage: 58%

@colemancda
Copy link
Member

Result of Integration 4

Duration: 2 minutes and 25 seconds
Result: Perfect build! All 22 tests passed. 👍
Test Coverage: 58%

@colemancda
Copy link
Member

Result of Integration 5

Duration: 2 minutes and 26 seconds
Result: Perfect build! All 23 tests passed. 👍
Test Coverage: 58%

3 similar comments
@colemancda
Copy link
Member

Result of Integration 5

Duration: 2 minutes and 26 seconds
Result: Perfect build! All 23 tests passed. 👍
Test Coverage: 58%

@colemancda
Copy link
Member

Result of Integration 5

Duration: 2 minutes and 26 seconds
Result: Perfect build! All 23 tests passed. 👍
Test Coverage: 58%

@colemancda
Copy link
Member

Result of Integration 5

Duration: 2 minutes and 26 seconds
Result: Perfect build! All 23 tests passed. 👍
Test Coverage: 58%

@colemancda colemancda changed the title Feature/new commads [#3] Implement all HCI LE Commands Apr 2, 2018
@colemancda
Copy link
Member

Result of Integration 5

Duration: 2 minutes and 26 seconds
Result: Perfect build! All 23 tests passed. 👍
Test Coverage: 58%

colemancda
colemancda previously approved these changes Apr 2, 2018
View reviewed changes
Copy link
Member

@colemancda colemancda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but still needs more HCI commands.

@colemancda
Copy link
Member

Result of Integration 28

Duration: 1 minute and 2 seconds
Result: 1 error, failing state: build-errors

1 similar comment
@colemancda
Copy link
Member

Result of Integration 28

Duration: 1 minute and 2 seconds
Result: 1 error, failing state: build-errors

@colemancda
Copy link
Member

Result of Integration 29

Duration: 2 minutes and 0 second
Result: All 71 tests passed, but please fix 2 warnings.
Test Coverage: 73%

3 similar comments
@colemancda
Copy link
Member

Result of Integration 29

Duration: 2 minutes and 0 second
Result: All 71 tests passed, but please fix 2 warnings.
Test Coverage: 73%

@colemancda
Copy link
Member

Result of Integration 29

Duration: 2 minutes and 0 second
Result: All 71 tests passed, but please fix 2 warnings.
Test Coverage: 73%

@colemancda
Copy link
Member

Result of Integration 29

Duration: 2 minutes and 0 second
Result: All 71 tests passed, but please fix 2 warnings.
Test Coverage: 73%

@colemancda
Copy link
Member

Result of Integration 30

Duration: 2 minutes and 0 second
Result: Perfect build! All 71 tests passed. 👍
Test Coverage: 73%

3 similar comments
@colemancda
Copy link
Member

Result of Integration 30

Duration: 2 minutes and 0 second
Result: Perfect build! All 71 tests passed. 👍
Test Coverage: 73%

@colemancda
Copy link
Member

Result of Integration 30

Duration: 2 minutes and 0 second
Result: Perfect build! All 71 tests passed. 👍
Test Coverage: 73%

@colemancda
Copy link
Member

Result of Integration 30

Duration: 2 minutes and 0 second
Result: Perfect build! All 71 tests passed. 👍
Test Coverage: 73%

@colemancda colemancda changed the title [#3] Implement all HCI LE Commands [#3] Implement HCI LE Commands Apr 11, 2018
@colemancda
Copy link
Member

Result of Integration 31

Duration: 1 minute and 58 seconds
Result: Perfect build! All 72 tests passed. 👍
Test Coverage: 73%

1 similar comment
@colemancda
Copy link
Member

Result of Integration 31

Duration: 1 minute and 58 seconds
Result: Perfect build! All 72 tests passed. 👍
Test Coverage: 73%

@colemancda
Copy link
Member

Result of Integration 31

Duration: 1 minute and 58 seconds
Result: Perfect build! All 72 tests passed. 👍
Test Coverage: 73%

@colemancda
Copy link
Member

Result of Integration 31

Duration: 1 minute and 58 seconds
Result: Perfect build! All 72 tests passed. 👍
Test Coverage: 73%

@colemancda
Copy link
Member

Result of Integration 32

Duration: 1 minute and 59 seconds
Result: Perfect build! All 73 tests passed. 👍
Test Coverage: 73%

@colemancda
Copy link
Member

Result of Integration 32

Duration: 1 minute and 59 seconds
Result: Perfect build! All 73 tests passed. 👍
Test Coverage: 73%

2 similar comments
@colemancda
Copy link
Member

Result of Integration 32

Duration: 1 minute and 59 seconds
Result: Perfect build! All 73 tests passed. 👍
Test Coverage: 73%

@colemancda
Copy link
Member

Result of Integration 32

Duration: 1 minute and 59 seconds
Result: Perfect build! All 73 tests passed. 👍
Test Coverage: 73%

@colemancda colemancda merged commit 60de81c into master Apr 11, 2018
@colemancda colemancda deleted the feature/new_commads branch April 11, 2018 12:55
@colemancda colemancda mentioned this pull request Apr 11, 2018
Open
carlos21 pushed a commit that referenced this pull request Jul 9, 2018
@colemancda
Merge pull request #21 from PureSwift/feature/new_commads
a40803d 
[#3] Implement HCI LE Commands
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@colemancda colemancda colemancda approved these changes

Assignees

@jmarkstar jmarkstar

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement all HCI LE Commands
2 participants
@jmarkstar @colemancda