Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Stop using AVStream.side_data #1570

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Stop using AVStream.side_data #1570

merged 1 commit into from
Oct 10, 2024

Conversation

WyattBlue
Copy link
Member

No description provided.

@hmaarrfk
Copy link
Contributor

This seems premature right?

@lgeiger
Copy link
Contributor

lgeiger commented Jan 21, 2025

This seems premature right?

I'd agree. Although since only DISPLAYMATRIX was exposed and the fact that AVStream.side_data seems to be undocumented it does make sense to remove it in favour of consistency. It might make sense to expose AvPacket.side_data in the future instead.

The problem for me was that this PR removed the only way to read the display rotation. However, #1675 brought back access to the rotation in a nicer API so this functionality will be accessible again in the next release.

@hmaarrfk
Copy link
Contributor

brought back access to the rotation in a nicer API so this functionality will be accessible again in the next release.

Understood.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants