Skip to content

Fix non_local_definitions lint triggers #3955

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2024
Merged

Fix non_local_definitions lint triggers #3955

merged 1 commit into from
Mar 13, 2024

Conversation

mejrs
Copy link
Member

@mejrs mejrs commented Mar 12, 2024

Fixes #3903

@mejrs mejrs added the CI-skip-changelog Skip checking changelog entry label Mar 12, 2024
@mejrs mejrs closed this Mar 12, 2024
@mejrs mejrs force-pushed the non_local_definitions2 branch from 21edde4 to a7fa1bd Compare March 12, 2024 13:39
@mejrs mejrs reopened this Mar 12, 2024
davidhewitt
davidhewitt approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for tidying this up! Nice to see a net negative diff from the simplification too 😄

@davidhewitt davidhewitt added this pull request to the merge queue Mar 12, 2024
Merged via the queue into PyO3:main with commit 989d2c5 Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix non_local_definitions warnings from RFC 3373
2 participants
@mejrs @davidhewitt