Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sector Updates #453

Merged
merged 41 commits into from
Nov 21, 2024
Merged

Sector Updates #453

merged 41 commits into from
Nov 21, 2024

Conversation

trevorb1
Copy link
Collaborator

@trevorb1 trevorb1 commented Oct 18, 2024

Closes #452, #468, #401, #395, #190

Changes proposed in this Pull Request

This PR includes a bunch of sector updates; including:

  • Correction of underground ng storage starting value if not using cyclic storage
  • Correction of import/export directions/limits on ng trade
  • Correction of ng marginal fuel prices. All components that use ng now use the endogenous price and a validation plot of ng price is added
  • Updates to road vehicle naming to add veh in name; to match non-road vehicles naming conventions
  • Corrections and updates to service sector brownfield stock data
  • Simple storage added for service level water heaters. This applies the investment constraint to the link, rather than the store, based on typical storage hours given as a configuration parameter.
  • Updates to ng import/export trade constraints to allow for user defined limits on both min/max imports/exports
  • Created constants for an array of sector specific values
  • Updated a bunch of plotting for sectors to be more robust. This includes a bit of a snakemake hack to read in the network once, but create state level charts for everything

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.

@trevorb1 trevorb1 merged commit a0d1dd9 into develop Nov 21, 2024
1 check failed
@trevorb1 trevorb1 deleted the issue-452 branch November 21, 2024 19:55
@trevorb1 trevorb1 mentioned this pull request Dec 1, 2024
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
1 participant