Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Inclusion of Enhanced Geothermal Systems (EGS) #490

Merged
merged 10 commits into from
Dec 19, 2024

Conversation

aljubrmj
Copy link
Contributor

@aljubrmj aljubrmj commented Dec 6, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

Changes included the option to allow for EGS build based on CONUS supply curves developed in https://www.nature.com/articles/s41598-024-68580-8. Scripts included data retrieval from zenodo repo and attaching EGS supply specs and profiles to the network, and adjustment of EGS decline over years in multihorizon configurations.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.

@ktehranchi ktehranchi self-requested a review December 6, 2024 23:16
@ktehranchi
Copy link
Collaborator

ktehranchi commented Dec 12, 2024

List of bugs to resolve:

  • 'nan' values for df_spec bus_id leads to no EGS data being added to the network if running non-USA interconnections
  • Extra "EGS existing" generators added to the network in add_extra components
  • Lifetime is set to 70 years or np.inf. In add_electricity they are set to np.inf.... the generators added in add_extra_components have lifetime of 70 years.
  • Add option to append custom cost data to main cost data


add_missing_carriers(n, carriers)
capital_recovery_period = 25 # Following EGS supply curves by Aljubran et al. (2024)
discount_rate = 0.07 # load_costs(snakemake.input.tech_costs).loc["geothermal", "wacc_real"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read from cost data

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually going to leave these as is- since I want to implement #499

@ktehranchi ktehranchi merged commit 77e1a3d into PyPSA:develop Dec 19, 2024
1 check was pending
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants