Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FEATURE] RoomAnalysis class for monaural room impulse response parameters calculation. #35

Merged
merged 11 commits into from
Jul 6, 2021

Conversation

Chum4k3r
Copy link
Collaborator

Developed this new class inside rooms.py to provide ways to calculate room parameters like Clarity, Definition, Early Decay Time, Reverberation Time and other.

It inherits from the Analysis class, so it is a class for calculating and viewing the parameters values, but still cannot cross reference impulse responses from different source-room-receiver arrangements, as if means and standard deviations are to be calculated together with the parameters. These still can be done with some looping through IRs and accessing the desired parameter data.

It also drops the need of Numba for JIT compilation of the reverberation time routines.

There is an example file that have a quick demonstration on how to instantiate a RoomParameters object and view its room evaluations.

Copy link
Collaborator

@mtslazarin mtslazarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, nice contribution \o/ I needed some time to analyse everything :>

Looks you are cropping the IR twice, I pointed in the code and commented a bit more. My suggestion to solve the problem is to calculate all the energy parameters from the EDC, maybe the energy compensation is something we want for the other parameters as well. Prof @eric-brandao can comment a bit more on this for sure.

About removing Numba dependency: I did some tests here, and for small calculations, it's okay to wait a bit more, but if you are calculating from many impulsive responses to do some sort of averaging and statistical analysis it would get painful. About making the toolbox compatible with ARM devices, is Numba the only thing that makes the toolbox useless on those devices? Is it worth to trade speed which is important to room-acoustics users for some compatibility with those devices?

@Chum4k3r Chum4k3r changed the title [FEATURE] RoomParameters for monaural room impulse response parameters calculation. [FEATURE] RoomAnalysis class for monaural room impulse response parameters calculation. Jul 5, 2021
Copy link
Collaborator Author

@Chum4k3r Chum4k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with a few different IRs I've found, including some from the last Round Robin and it runs ok. Believe it is now ready for merge.

@Chum4k3r Chum4k3r merged commit 2a566f6 into PyTTaMaster:development Jul 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Clarity and Definition calculation in rooms module
2 participants