necessary changes in deconvolution with regularization, and other stuff #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Necessary changes to deconvolution. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the spectrum division function with regularization to allow the user to pass a list of [freq_min, freq_max] as in Ita toolbox. The way it was, the function was taking the inputSignal.freqMin and inputSignal.freqMax, which are the values where the sweep is just starting to fade in or had already faded out. This is incorrect and noise prone.
I also added another deconvolution method that still need some review (mainly to correct a bias in the level of the h(t).
I am migrating deconvolution methods to functions inside the ImpulseResponse class - easier to mantain.