-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Additional documentation for cwt (issue #676) #678
Conversation
Wow, I was not expecting test failures, since I only touched the documentation. Seems like there is a warning since version 3.9 about some out-of-date |
Thanks for this PR @drs251. Let me resolve the failures in a separate PR, and then rebase this one on top. |
…ble of contents in index.rst more detailed.
This is green now 😅. @drs251 did you commit the |
@rgommers Thanks for fixing the test failures so quickly. Regarding the |
@rgommers I got rid of the |
Thanks! Sphinx had a lot of regressions in 7.2.X recently, so that may be it. As long as the lower resolution still looks good on screen, that should be fine though. No need to dig into the potential Sphinx issue I'd think. |
@rgommers I'm actually happy with the way the plot looks, the resolution is good enough to convey the point: Is there anything left to do before the PR can be merged? |
@rgommers Just wondering if there anything left to do before the PR can be merged? From my point of view, it‘s ready to go 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @drs251. Sorry about the long delay - neither me nor another maintainer had any time for PyWavelets around the time you opened this PR.
I now resolved the merge conflicts, did a copy-edit, and made some minor changes to plot_wavelets.py
to avoid using deprecated forms of string wavelet names.
The added content is quite nice, thank you.
A plot of all available wavelets for CWT, and a comparison of the outcome using wavelets with different center frequencies and bandwidths. (for some reason, generating the corresponding images with a Python script slowed down Sphinx massively, so I ended up using pre-made images, as I could not figure out a better solution).
It's not super fast, but it doesn't bother me much right now - total doc build time seems reasonable.
While I was at it, I could not resist to increase the depth of the table of contents in index.rst to 2 - this makes it much easier to find individual pages.
In the meantime we just changed to a new doc theme and moved the toctree to the top of the page, plus have a better navbar. I hope that helps with the discoverability. If not, let's deal with this separately. :maxdepth: 2
wass too much.
Merged in preparation for the next release. Thanks again @drs251! |
This PR is in response to issue #676. Basically, I wrote the documentation I wish I had when I started messing with the CWT 😄. Here's a summary of the proposed changes:
Looking forward to constructive criticism.