Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Spec as absolute path not absolute URI #238

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

Jmennius
Copy link
Contributor

This should resolve any issues one might have with serving Swagger UI behind a reverse proxy where protocols or ports change, without any additional configuration.

Fixes: #176
Refs: #207

@zupo
Copy link
Collaborator

zupo commented Apr 17, 2024

I'll give this a try in a few of my projects and report back.

@zupo
Copy link
Collaborator

zupo commented Apr 20, 2024

It works for me in all use cases I can think of, so I'm +1 on merging this.

But before I do, @Jmennius could you please remove the now obsolete proto_port from the codebase? I'll make sure to bump the version and add to release notes that we have a breaking change.

@zupo
Copy link
Collaborator

zupo commented Apr 20, 2024

Hey @jschaeff and @vpet98, you were both involved with bringing in proto_port that we are now making obsolete. Can you read through this PR and raise concerns, if you have any, please?

This should resolve any issues one might have with serving Swagger UI
behind a reverse proxy where protocols or ports change,
without any additional configuration.

Signed-off-by: Ievgen Popovych <ievgenp@seetrue.ai>
@Jmennius Jmennius force-pushed the spec-as-absolute-path-not-absolute-URI branch from 5b69f92 to df16e48 Compare April 20, 2024 18:07
@Jmennius
Copy link
Contributor Author

It works for me in all use cases I can think of, so I'm +1 on merging this.

But before I do, @Jmennius could you please remove the now obsolete proto_port from the codebase? I'll make sure to bump the version and add to release notes that we have a breaking change.

Done. I've reverted the commit almost cleanly (left one blank line fix, hope it was a fix :)).
I understand that you'll write change on github releases yourself?

Thanks!

@zupo zupo merged commit 652cdc1 into Pylons:main Apr 24, 2024
3 checks passed
@Jmennius Jmennius deleted the spec-as-absolute-path-not-absolute-URI branch April 25, 2024 10:26
@jschaeff
Copy link

Thank you for this work and merging in main. Great work !

Sorry for not being very reactive, I was on vacations.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explorer UI refers to wrong procol if operated behind referse proxy with HTTPS
3 participants