openapicore case insensitive header fix

[sjiekak]

fixes #87

[zupo]

Fix looks good but my "I'll fix it later" CI script that enables us to test the minimal supported version of openapi-core needs to be updated any time we bump openapi-core: https://github.com/Pylons/pyramid_openapi3/blob/master/inject_minimal_openapi-core.sh

I likely won't be able to do this before next week, so if you are in a hurry to get this PR merged, you can try and see if you can decipher how it works.

[sjiekak]

So I'm bumping the script as well. I preserved the the hash order in the Pipfile.lock file as well as how the minimal supported version was injected, even if they are currently the same.

[zupo]

Suggested change

	sed -i 's/"==0.13.4"/"==0.13.4"/g' Pipfile.lock
	sed -i 's/"==0.13.4"/"==0.13.1"/g' Pipfile.lock

[zupo]

Suggested change

	sed -i s/b8b4283d84038495fb3bde4a868cd9377272ecf898f142d7706d6d49fc14d218/b8b4283d84038495fb3bde4a868cd9377272ecf898f142d7706d6d49fc14d218/g Pipfile.lock
	sed -i s/b8b4283d84038495fb3bde4a868cd9377272ecf898f142d7706d6d49fc14d218/d61305484f8fefda78fdddaf8890af6804fae99dff94013abd9480873880bddc/g Pipfile.lock

[zupo]

0.13.4's hash needs to be replaced by our "minimal supported version of openapi-core"'s hash, so that this minimal version gets tested on CI.

[sjiekak]

Hey @zupo. Unless we write retro-compatible code, this version will not be able to support older version of openapi-core

[sjiekak]

Something like this

        header = request.headers.items()
        if openapi_core.__version__ < '0.13.4':
            header = request.headers

[zupo]

Ah, I understand it now, sorry for the noise.

I don't have a strong opinion about whether we need to write retro-compatible code, I usually stick to latest releases. But if you want you can add retro-support, I'm really fine either way.

Can you make sure that we update the minimal version to 0.13.4 wherever 0.13.1 is mentioned? Probably some constraints somewhere? (sorry for vagueness, not at may workstation)

[sjiekak]

Can you make sure that we update the minimal version to 0.13.4 wherever 0.13.1 is mentioned

Thanks for the remark, I forgot to update the setup file.

[zupo]

Looks good!

[zupo]

Ah, snap. The way CI is set up is that it shares pipenv caches between py37 and py38 if Pipfile.lock is not different between the two -> which with this PR, Pipfile.lock is the same, since minimal openapi-core version is the same as current openapi-core version. And sharing the cache makes pipenv break.

I'll think about it. Probably add retro-compatiblity becaues it's easier then fiddleing with CI.

[sjiekak]

I wrote a retro-compatible version. I feel like there is an action needed on your part to clean up the cache.

[zupo]

Superseded by #89.