Update report_timing() to support context manager API #3039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This updates the old
report_timing()
function so that it can be used as a context manager. When used as a context manager, it will undo the changes that it made to the timing loggers upon exit from the context. Among other things, this prevents side effects from enabling report_timing inmodel.create_instance()
and makes it easier to exercise the timing statements in the transformations and writers.This also adds a test that exercises the timing reporting for the NLv2 (which was the original motivation)
Changes proposed in this PR:
report_timing()
to support use as a context managerreport_timing()
context manager inModel.create_instance()
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: