Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Hot fix - Client ID is now needed with every request to the Kraken API #17

Closed
wants to merge 1 commit into from

Conversation

Coriou
Copy link

@Coriou Coriou commented Sep 16, 2016

You can read (a little bit) more about this issue here :
justintv/Twitch-API#609

Since today (Sept., 16th 2016) all calls to the Kraken API require you
to send a valid client id.

This is a hotfix, using the client id provided by pytwitcher. Maybe a
better implementation would be to allow the user to provide it’s own
client id.

At least, now this library is functional again for those using it in
production !

You can read (a little bit) more about this issue here :
justintv/Twitch-API#609

Since today (Sept., 16th 2016) all calls to the Kraken API require you
to send a valid client id.

This is a hotfix, using the client id provided by pytwitcher. Maybe a
better implementation would be to allow the user to provide it’s own
client id.

At least, now this library is functional again for those using it in
production !
storax added a commit that referenced this pull request Sep 16, 2016
@storax
Copy link
Member

storax commented Sep 16, 2016

Hi,

thank you very much for submitting this pull request and also for being so fast on the issue.
I released a new version 0.9.0 with some minor changes and test fixes.
The Client ID can now be set via the environment variable PYTWITCHER_CLIENT_ID.
Please note that the latest version of irc is required.
I'm sorry that I'm not going to merge this but I've included you into the list of contributors.
Really appreciate your contribution and hope you will find this useful.
If there is anything that I've missed or did wrong, feel free to create an issue/pull request.

Cheers,
David

@storax storax closed this Sep 16, 2016
@Coriou
Copy link
Author

Coriou commented Sep 18, 2016

Thanks for fixing it ! It's no problem at all that you don't merge it, it's a crappy hotfix anyway, it's just that I needed a fix real quick and I thought I might as well share it, but definitely not a proper implementation.

Thank you for taking care of this so quickly !

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants