Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change list total to absolute positioning #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change list total to absolute positioning #98

wants to merge 2 commits into from

Conversation

mateusnroll
Copy link

Since Trello added the ellipsis button to the right, the list total was breaking to the second line.
screen shot 2016-04-11 at 9 59 04 pm

This makes it absolute positioned and hence fixes the issue – I hope :). It fixes #97. The updated build looks like this:
screen shot 2016-04-11 at 10 04 55 pm

I went with the absolute positioning because:

  1. It will be less likely to break something they introduce. The alternate approach would be to change the .list-header to a flex container, which means messing with Trello's CSS – I guess it's not something I should be doing unless necessary.
  2. The ellipsis button is already using absolute positioning, so why not?
  3. Changing to a flex container would break the card count, this does not.

I hope this helps 👍

Mateus Pinheiro added 2 commits April 11, 2016 22:06
Since Trello added the ellipsis button to the right, the list total was
breaking to the second line. This makes it absolute positioned and
hence fixes the issue – I hope :)
Since fixing the column totals makes them absolute, it also affected
the board total. This makes the board totals not break.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken list count
1 participant