Closing a paused terminal with the spacebar triggers QuickLook

[cbuchart]

1. User calls a batch file which internally calls pause before finishing (Press any key to continue . . .).
2. User presses the Spacebar to close the window.
3. QuickLook unexpectedly previews the batch file.

Attached a very simple test case (it is zipped because cannot upload .bat directly)

test.zip

[xupefei]

Hi, I have tested this .bat file but the QuickLook didn't popped up. I think you are pressing the SPACE key when focusing the file in explorer window, not the cmd window.
QuickLook will popup preview window when (i) the current foreground window is the desktop or an explorer window & (ii) there is a file selected. Therefore the window should not pop up in your case since (i) is not satisfied.

[cbuchart]

No, I've double-checked that the focus is on the terminal, otherwise the terminal windows wouldn't close. More information: Windows 10 (1703, 15063.296). If I can get more information about it I'll let you know.

[xupefei]

Thanks for the response. What version of quicklook are you using?

…

On 6 Jun 2017 10:07, "Carlos Buchart" ***@***.***> wrote: No, I've double-checked that the focus is on the terminal, otherwise the terminal windows wouldn't close. More information: Windows 10 (1703, 15063.296). If I can get more information about it I'll let you know. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABnBJ8TwXDpoExdE08jjGFUHWh3LMgITks5sBPrAgaJpZM4NrakP> .

[cbuchart]

latest so far: 0.1.13

[xupefei]

Finally I figured out how to reproduce it issue. A .bat on Desktop would not work, but one in a explorer window.
I think it is because the KeyUp/KeyDown sequence. The cmd window closes in KeyDown, but QuickLook is handling KeyUp. I will fix this asap.

[cbuchart]

0.1.14 works flawlessly, nice bug fixing, thanks!