Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

An error occurs when reading file names containing URL-encoded strings. #825

Closed
Pengtasia opened this issue Jan 21, 2021 · 2 comments
Closed

Comments

@Pengtasia
Copy link

Pengtasia commented Jan 21, 2021

For all's convenience, please use English to fill this issue.
I'll do my best.

Please search within existing issues before the submission. Has this issue already been reported?
Already done... maybe...?

Describe the bug
An error occurs when reading file names containing URL-encoded strings.

To Reproduce
Steps to reproduce the behavior:

  1. Convert a string in a Non English using URL-Encoding. (Like Korean)
    ex) %EC%A0%9C%EB%AA%A9_%EC%97%86%EC%9D%8C-1.jpg
  2. Rename file using That string.
  3. Hit space key at File Explorer.
  4. An error occurs!

Expected behavior

Desktop (please complete the following information):

  • OS Version: Windows 10 20H2 (19042.746)
  • QuickLook Version: v3.6.10 (UWP)

Screenshots and Exception Log
If applicable, add screenshots and logs to help explain your problem. The log file is located in one of several locations.

QuickLook.Exception.log

Screenshot_20210121_144517_001

%EC%A0%9C%EB%AA%A9_%EC%97%86%EC%9D%8C-1

@xupefei
Copy link
Member

xupefei commented Jan 21, 2021

It seems string->Uri conversion is doing something we don't want it to do.

I have recently made some change there and not sure if the problem still exists. Could you try the Nightly version https://ci.appveyor.com/project/xupefei/quicklook/build/artifacts?

@Pengtasia
Copy link
Author

Unfortunately same problem...

xupefei added a commit that referenced this issue Mar 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants