-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Replace supported image extension list with image detection via MagickImageInfo. #818
Conversation
My main concern is ImageMagick handles way more file types than images, such as PDF. |
Good point. With ffmpeg installed it'll also try to handle video formats. VideoViewer has priority -10. I guess prio values would need to be VideoViewer > ImageViewer > TextViewer. E.g. -3, -4, -5 ; comment in VideoViewer says "make it lower than TextViewer" but not why. |
It was changed to lower than TextViewer here: 24c0316 I see .ts as a video file extension, so if video was > text it would try to view typescript files as video. So I can see why video would need to be lower that text if video only goes by file extension. :( |
Change VideoViewer priority to -3 and detect audio/video via MediaInfo instead of file extensions.
Tried to do the same in VideoViewer and detect audio/video file via MediaInfo instead of file extensions. See latest WIP - currently re-creates MediaInfo in both CanHandle and Prepare. Out of time for today... |
Add some notes about MediaInfo Open and Close.
If there was an exception due to MediaInfo it would have already occurred in CanHandle.
Build artifacts for the latest here: |
Does it also support .jfif files? EDIT: This was added in a test build 4 months ago |
@Michael82548 yes, should work. Both in the nightly build (https://github.com/QL-Win/QuickLook#downloadinstallation) as well as the test build for this merge request above. |
I'm quite busy in the past few days. Will try to review this PR by this weekend. |
For other image formats, let ImageMagick try to detect by file content. Upgrade to latest Magick.NET
Great job, thanks! |
@mooflu |
I disabled detecting images using ImageMagick due to:
|
Fixes #802 #768