Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

Remove extra decompose in RuntimeEncoder #1094

Merged
merged 4 commits into from
Dec 8, 2021

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Dec 7, 2021

Summary

RuntimeEncoder does an extra decompose() if the circuit is a BlueprintCircuit, to address a QPY issue. The issue has since been merged and deployed, and this extra decompose is causing QAOA runtime program to fail.

Details and comments

@rathishcholarajan
Copy link
Member

@jyu00 do we need a release note and a patch release?

@jyu00
Copy link
Collaborator Author

jyu00 commented Dec 8, 2021

@rathishcholarajan Yup just added a release note. And yes we'll need a patch release. Terra is planning a patch release for Thursday so we can do it at the same time.

@rathishcholarajan rathishcholarajan added the Changelog: Bugfix Include in the Fixed section of the changelog label Dec 8, 2021
Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jyu00!

@rathishcholarajan rathishcholarajan merged commit 8455b01 into Qiskit:master Dec 8, 2021
@rathishcholarajan rathishcholarajan added the backport potential The bug might be minimal and/or import enough to be port to stable label Dec 8, 2021
rathishcholarajan pushed a commit to rathishcholarajan/qiskit-ibmq-provider that referenced this pull request Dec 8, 2021
* remove extra decompose

* fix lint

* fix lint again

* add release note
rathishcholarajan added a commit that referenced this pull request Dec 8, 2021
* Remove extra decompose in RuntimeEncoder (#1094)

* remove extra decompose

* fix lint

* fix lint again

* add release note

* Update release note with link to PR since there was no issue created

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants