-
Notifications
You must be signed in to change notification settings - Fork 145
Allow users to set a logging level for runtime jobs (#99) #1117
Conversation
* allow log levle * fix docstring * doc levels (cherry picked from commit 32607d6)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment... Could you please add a release note as well?
from ..exceptions import IBMQInputValueError | ||
|
||
|
||
@dataclass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see dataclass is a Python 3.7+ feature. We still support Python 3.6 for the upcoming provider release since terra 0.19.x still supports it and then it will be dropped after the 0.19.0 provider release. Would this work with Python 3.6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But Python 3.6 end of life was more than a month ago, and the latest qiskit-terra no longer supports 3.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add dataclasses>=0.8;python_version<'3.7'
to the requirements list. Being in the metapackage puts extra requirements and for the metapackage we've got more conservative support versions and we've previously advertised that terra 0.19.x (and aer 0.10.x) supports python 3.6. So we can't add anything to the metapackage that requires >3.6 until we release terra 0.20.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jyu00 Could you please add dataclasses to setup.py as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @jyu00!
Summary
Backport from Qiskit/qiskit-ibm-runtime#99
Allows users to specify a custom logging level for runtime jobs
Details and comments