Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

Allow users to set a logging level for runtime jobs (#99) #1117

Merged
merged 5 commits into from
Feb 9, 2022

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Feb 2, 2022

Summary

Backport from Qiskit/qiskit-ibm-runtime#99

Allows users to specify a custom logging level for runtime jobs

Details and comments

jyu00 added 2 commits February 2, 2022 10:59
* allow log levle

* fix docstring

* doc levels

(cherry picked from commit 32607d6)
@rathishcholarajan rathishcholarajan added the Changelog: New Feature Include in the Added section of the changelog label Feb 2, 2022
Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment... Could you please add a release note as well?

from ..exceptions import IBMQInputValueError


@dataclass
Copy link
Member

@rathishcholarajan rathishcholarajan Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see dataclass is a Python 3.7+ feature. We still support Python 3.6 for the upcoming provider release since terra 0.19.x still supports it and then it will be dropped after the 0.19.0 provider release. Would this work with Python 3.6?

Copy link
Collaborator Author

@jyu00 jyu00 Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But Python 3.6 end of life was more than a month ago, and the latest qiskit-terra no longer supports 3.6.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add dataclasses>=0.8;python_version<'3.7' to the requirements list. Being in the metapackage puts extra requirements and for the metapackage we've got more conservative support versions and we've previously advertised that terra 0.19.x (and aer 0.10.x) supports python 3.6. So we can't add anything to the metapackage that requires >3.6 until we release terra 0.20.0

Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyu00 Could you please add dataclasses to setup.py as well?

Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jyu00!

@rathishcholarajan rathishcholarajan merged commit b2d1912 into Qiskit:master Feb 9, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants