This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Fix job date filtering for between #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyu00
reviewed
Nov 18, 2019
test/ibmq/test_ibmq_job.py
Outdated
| @requires_device | ||
| def test_get_jobs_filter_date_backend(self, backend): | ||
| @requires_provider | ||
| def test_get_jobs_filter_date_backend(self, provider): |
There was a problem hiding this comment.
I don't think it's all that necessary to have a separate test case for backend.jobs(), since it just calls backendservice.jobs() (but I suppose there is no harm since it's quick - your decision). It'd be more useful to have a test case that specifies both datetime as keyword and inside db_filter, for example start_date=past_month, db_filter={'creationDate': {'lt': past_two_month}}
* add error code in message * lint issue
…bmq-provider into fix-filter-query
jyu00
approved these changes
Nov 18, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #450
Related to #442
Details and comments