Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

add refresh to ibmqjob.result #469

Merged
merged 9 commits into from
Dec 4, 2019

Conversation

lgarc15
Copy link
Contributor

@lgarc15 lgarc15 commented Nov 26, 2019

Summary

Addresses #466

Details and comments

@jyu00
Copy link
Collaborator

jyu00 commented Nov 26, 2019

Can you also update the changelog? Since you're changing a user facing method.

@jyu00
Copy link
Collaborator

jyu00 commented Dec 4, 2019

One more thing. We should get into the habit of specifying the default value (e.g. Default: foo) in the docstring so users can get that information from the api doc (when it's available) instead of having to look at the code.

@lgarc15
Copy link
Contributor Author

lgarc15 commented Dec 4, 2019

One more thing. We should get into the habit of specifying the default value (e.g. Default: foo) in the docstring so users can get that information from the api doc (when it's available) instead of having to look at the code.

Went back to add the default values for this PR. I'll make sure to do so in future ones as well 👍

@lgarc15 lgarc15 requested a review from jyu00 December 4, 2019 18:29
@jyu00 jyu00 merged commit af4f413 into Qiskit:master Dec 4, 2019
@lgarc15 lgarc15 deleted the add-refresh-to-ibmqjob-result branch December 16, 2019 15:50
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants