This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Retrieve managed jobs #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # qiskit/providers/ibmq/ibmqbackendservice.py
…jobs # Conflicts: # qiskit/providers/ibmq/managed/ibmqjobmanager.py # qiskit/providers/ibmq/managed/managedjob.py # qiskit/providers/ibmq/managed/managedjobset.py
…jobs # Conflicts: # qiskit/providers/ibmq/api/clients/account.py # qiskit/providers/ibmq/ibmqbackend.py # qiskit/providers/ibmq/managed/ibmqjobmanager.py # qiskit/providers/ibmq/managed/managedjob.py # qiskit/providers/ibmq/managed/managedjobset.py
…jobs # Conflicts: # qiskit/providers/ibmq/api/clients/account.py # qiskit/providers/ibmq/ibmqbackend.py # qiskit/providers/ibmq/ibmqbackendservice.py # qiskit/providers/ibmq/job/ibmqjob.py # qiskit/providers/ibmq/managed/ibmqjobmanager.py # qiskit/providers/ibmq/managed/managedjob.py # qiskit/providers/ibmq/managed/managedjobset.py
…jobs # Conflicts: # CHANGELOG.md
lgarc15
reviewed
Jan 15, 2020
lgarc15
approved these changes
Jan 16, 2020
| # Verify the job is proper. | ||
| matched = pattern.match(job.name()) if job.name() else None | ||
| if not matched or matched.group(1) != self._name or \ | ||
| job.backend().name != self._backend.name: |
There was a problem hiding this comment.
You must have forgot to call the name() method: job.backend().name() != self._backend.name() 😅
|
Approved the changes since everything looked good! I just left one comment on a last minor change above. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #481
Details and comments